Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LONDON | SHIRIN PANAHIAN | feature/wireframe | WEEK1 #300

Closed

Conversation

shirinpanahian
Copy link

@shirinpanahian shirinpanahian commented Oct 29, 2024

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for cyf-ufd ready!

Name Link
🔨 Latest commit a3ab6ca
🔍 Latest deploy log https://app.netlify.com/sites/cyf-ufd/deploys/6721636080709b0008540a37
😎 Deploy Preview https://deploy-preview-300--cyf-ufd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Grajales-K Grajales-K added the Needs Review Participant to add when requesting review label Oct 31, 2024
@rosb-code
Copy link

rosb-code commented Oct 31, 2024

Hi @shirinpanahian , I can see a good work here!
I left a few comments more focused in the organization ot the code, if you have any questions, don't hesitate to ask!

Observation: When submitting a PR, briefly explain your PR, so the reviewer can have a general view of what you've done.

<p>Copyright © 2024 Code Your Future. All Rights Reserved.</p>
<span class="footer-email">Email:<a href="mailto:[email protected]" >[email protected]</a></span>
</footer>
</body>
</html

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to close de tag here: </html>

<a href="#" class="read-btn">Read More</a>
</section>
</main>
</div>
<!-- Add your HTML markup here -->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments that you no longer need, you may remove it. It will make the code more clean.

</section>

<section class="column">
<img src="image/img2.png" alt="git-developer">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: when adding pictures, putting a good name on it, makes the code cleaner . Another suggestion is to use "alt" to describe the picture, like this: <img src="image/img2.png" alt="Git Developer">

}

.container section:first-child{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could erase this blank line.

@rosb-code rosb-code added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants